Skip to content

[#25465] Support multi-select endpoint deletion and fixed a typo (backport #257)#259

Closed
mergify[bot] wants to merge 1 commit into
2.14.xfrom
mergify/bp/2.14.x/pr-257
Closed

[#25465] Support multi-select endpoint deletion and fixed a typo (backport #257)#259
mergify[bot] wants to merge 1 commit into
2.14.xfrom
mergify/bp/2.14.x/pr-257

Conversation

@mergify

@mergify mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown

Description

This PR improves endpoint management in the Qt UI by allowing multiple endpoints to be selected and removed in one action.

It also fixes the Delete Enpoint typo in the context menu label.

Local steps to test it

  1. Single-click selects one endpoint row
  2. Press keyboard key "Ctrl"/"Shift"
    2.1 Ctrl + click adds or removes individual rows from the selection
    2.2 Shift + click selects a contiguous row range
    2.3 Shift + <up/down> adds or removes individual adjacent row from the selection
  3. Deletion
    3.1 Pressing Delete removes all selected endpoints
    3.2 Right-clicking a selected row keeps the current multi-selection

Documentation PR

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • Changes do not break current interoperability.

  • New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.
This is an automatic backport of pull request #257 done by [Mergify](https://mergify.com).

@Danipiza @mergify
Add multi-select endpoint deletion and fixed 'Delete Endpoint' typo (#…
969a2d5 
…257)

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
(cherry picked from commit 2113d28)

# Conflicts:
#	include/eprosimashapesdemo/qt/mainwindow.h
@mergify

mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown
Author

Cherry-pick of 2113d28 has failed:

On branch mergify/bp/2.14.x/pr-257
Your branch is up to date with 'origin/2.14.x'.

You are currently cherry-picking commit 2113d28.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   forms/mainwindow.ui
	modified:   src/qt/mainwindow.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   include/eprosimashapesdemo/qt/mainwindow.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify Bot added the conflicts Backport PR wich git cherry pick failed label Jun 25, 2026
@mergify mergify Bot mentioned this pull request Jun 25, 2026
Merged
8 tasks
@MiguelCompany MiguelCompany added this to the v2.14.7 milestone Jun 25, 2026
@Danipiza

Danipiza commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Closing this PR as it is not required for backporting. The changes introduce a new feature that is intended to live only in the main branch and should not be included in stable/release branches

@Danipiza Danipiza closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

conflicts Backport PR wich git cherry pick failed

Projects

None yet

Milestone

v2.14.7

Development

Successfully merging this pull request may close these issues.

2 participants

@Danipiza @MiguelCompany